scanner: Fix hyprwire_protocol cmake function#4
Open
hyperair wants to merge 1 commit intohyprwm:mainfrom
Open
Conversation
- Copy isClient logic from main CMakeLists.txt protocol function - Separate protoName and protoFile parameters for when there's a mismatch
Author
|
Tested with the following cmake_minimum_required(VERSION 3.19)
project(hyprwire_tests LANGUAGES CXX)
enable_testing()
set(CMAKE_CXX_STANDARD 23)
add_compile_options(
-Wall
-Wextra
-Wpedantic
-Wno-unused-parameter
-Wno-unused-value
-Wno-missing-field-initializers
-Wno-narrowing
-Wno-pointer-arith)
find_package(PkgConfig REQUIRED)
pkg_check_modules(hyprwire REQUIRED IMPORTED_TARGET hyprwire)
find_package(hyprwire-scanner REQUIRED)
include_directories(${CMAKE_BINARY_DIR})
link_libraries(PkgConfig::hyprwire)
add_executable(server tests/Server.cpp)
add_executable(client tests/Client.cpp)
set(generatedDir generated)
# needs https://github.com/hyprwm/hyprwire/pull/4
hyprwire_protocol(
server
FALSE
"${generatedDir}"
"test_protocol_v1"
${CMAKE_SOURCE_DIR}/tests
"protocol-v1.xml"
)
hyprwire_protocol(
client
TRUE
"${generatedDir}"
"test_protocol_v1"
${CMAKE_SOURCE_DIR}/tests
"protocol-v1.xml"
) |
Member
|
eh to be honest I'd nuke it anyways we dont use it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the
hyprwire_protocolcmake function, which is currently broken in a number of waysisClientlogic from mainCMakeLists.txtprotocol function to handle the-clientand-serversuffixes in the generated filenames.protoNameandprotoFileparameters for when there's a mismatch between the protocol name in the XML file and the filename of the protocol.xml file.